microsoft / microsoft/react-native-windows
Add New JSI APIs to Windows
@vmoroz is already working on this.
Since Jan 9, 2025.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Meta has recently added several JSI APIs we should implement these on Windows. Here are the commits for the new APIs:
- Add default implementation for Object.getPrototypeOf and Object.setPrototypeOf https://github.com/facebook/react-native/commit/04f33ecd58505014241b03ca60badfdb740d6935
- Add default getStringData/getPropNameIdData implementation https://github.com/facebook/react-native/commit/c6f12254d16d87978383c08065a626d437e60450
- Add default implementation for Object.create(prototype) https://github.com/facebook/react-native/commit/e34c1e9bd25073a5ff687ecb51bc2918e9aaf2f1
Note: Tests in testlib.cpp(https://github.com/microsoft/react-native-windows/blob/main/vnext/ReactCommon/TEMP_UntilReactCommonUpdate/jsi/jsi/test/testlib.cpp) have been temporarily disabled until this APIs are implemented for Windows. These tests should be reenabled once the APIs are implemented.
These changes were integrated into RNW in https://github.com/microsoft/react-native-windows/pull/14249 and https://github.com/microsoft/react-native-windows/pull/14235 integrations.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.