microsoft / microsoft/react-native-windows
Remove override for NativeDOM pointer events casting double to int32_t
@HariniMalothu17 is already working on this.
Since Nov 24, 2025.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Problem Description
In the upstream ReactCommon NativeDOM.cpp there are some implicit casts from doubles to PointerIdentifiers (int32_t) which flag as warnings for us. In the integration we disabled warnings, but that causes BinSkim to complain and fail our builds.
I fixed the issue by creating an override and performing the cast, but this issue should be resolved upstream.
Link to the integration where the error originated
https://github.com/microsoft/react-native-windows/pull/14092
Link to commit
https://github.com/facebook/react-native/commit/0267ca0a4020bbe3226b27d0f6514febf1f0511b
Forked files
ReactCommon\react\nativemodule\dom\NAtiveDOM.cpp
Upstream PR
https://github.com/facebook/react-native/pull/48578
Build Configuration
None
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.