microsoft / microsoft/react-native-windows
Unfork ComponentDescriptorRegistry.cpp
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Problem Description
Broke pages for Glyph UWP, Fabric Native Component, and Fabric Native Component Yoga. It looks like the removed the fallback if there's no component descriptor. Need to figure out if we want to make an upstream change to add these back in or change our implementation.
Link to the integration where the error originated
https://github.com/microsoft/react-native-windows/pull/14167
Link to commit
Forked files
- ComponentDescriptorRegistry.cpp
Upstream PR
No response
Build Configuration
None
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with ComponentDescriptorRegistry.cpp and compare the fork with the upstream commit linked in the issue. Check the affected Glyph UWP, Fabric Native Component, and Fabric Native Component Yoga pages using the integration from PR #14167. Done means the fallback behavior is restored through an agreed upstream or local change and those pages work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100