microsoft / microsoft/react-native-windows

Add utf16 to JSI

Open
#14,185 2 comments 0 reactions 1 assignee View on GitHub

@vmoroz is already working on this.

Since Dec 12, 2024.

  • #14650 by @anupriya13 — merged
Area: JSI enhancement Integration Follow-up
Dominant language
C++
Stars
17.3k
Forks
1.2k
Avg merge
1d 13h
Merged PRs (30d)
33

Description

Problem Description

Recent integration brings in https://github.com/facebook/react-native/pull/47356 which we need to update the JSI files in our repo and Hermes-windows repo to add utf16 method. Since this isn't being used in any code yet, I was able to just disable to test to get the integration building!

There were also these two PRs in the integration that may need to be pulled into the hermes-repo: https://github.com/facebook/react-native/pull/47331 and https://github.com/facebook/react-native/pull/47422

Link to the integration where the error originated

https://github.com/microsoft/react-native-windows/pull/14167

Link to commit

https://github.com/facebook/react-native/pull/47356
https://github.com/facebook/react-native/pull/47331
https://github.com/facebook/react-native/pull/47422

Forked files
  1. testlib.cpp
Upstream PR

No response

Build Configuration

None

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.