microsoft / microsoft/react-native-windows

TurboModuleImpl should override create instead of get to take advantage of caching

Open
#14,132 0 comments 0 reactions 1 assignee View on GitHub

@acoates-ms is already working on this.

Since Nov 21, 2024.

Area: Turbo Modules enhancement Integration Follow-up New Architecture
Dominant language
C++
Stars
17.3k
Forks
1.2k
Avg merge
1d 13h
Merged PRs (30d)
33

Description

TurboModuleImpl currently implements TurboModule::get.

Instead it should override create. This would allow TurboModuleImpl to take advantage of the caching layer in TurboModule. And will be required in the future when Meta updates get to be final.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.