microsoft / microsoft/react-native-windows

Internal RNW Codegen should output to FBReactNativeSpecJSI

Open
#14,129 0 comments 0 reactions 1 assignee View on GitHub

@acoates-ms is already working on this.

Since Nov 21, 2024.

Area: JSI enhancement Integration Follow-up
Dominant language
C++
Stars
17.3k
Forks
1.2k
Avg merge
1d 13h
Merged PRs (30d)
33

Description

Internal headers such as the default turbo modules, expect the codegen'd files to be located at FBReactNativeSpecJSI/FBReactNativeSpecJSI.h

Currently our codegen outputs to codegen. This requires an additional header located at FBReactNativeSpecJSI/FBReactNativeSpecJSI.h that just #include's <codegen/rnwcoreJSI.h>

We should consider modifying the codegen logic to locate the generated files at a compatible location.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.