microsoft / microsoft/react-native-windows

Unfork NetworkIOAgent files and Utf8.h

Open
#13,587 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area: Networking bug Integration Follow-up Workstream: Releases and Integrations
Dominant language
C++
Stars
17.3k
Forks
1.2k
Avg merge
1d 13h
Merged PRs (30d)
33

Description

Problem Description

Integration added these files which have multiple issues with types and annoyonous namespace. Currently have a fix in an override file but need verification that it was handled correctly before making a PR upstream.

image

Link to the integration where the error originated

https://github.com/microsoft/react-native-windows/pull/13554

Link to commit

https://github.com/facebook/react-native/pull/45426
https://github.com/facebook/react-native/pull/45445
https://github.com/facebook/react-native/commit/193cdc36f7de5524b509e38da8feb209d214634c

Forked files
  1. vnext\ReactCommon\TEMP_UntilReactCommonUpdate\jsinspector-modern\NetworkIOAgent.cpp
  2. vnext\ReactCommon\TEMP_UntilReactCommonUpdate\jsinspector-modern\NetworkIOAgent.h
  3. vnext\ReactCommon\TEMP_UntilReactCommonUpdate\jsinspector-modern\Utf8.h
Upstream PR

N/A

Build Configuration

Debug

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the three forked files under vnext\ReactCommon\TEMP_UntilReactCommonUpdate\jsinspector-modern: NetworkIOAgent.cpp, NetworkIOAgent.h, and Utf8.h. Compare them with the referenced React Native PRs and commit, then inspect the existing override fix and verify the reported type and anonymous-namespace issues. Done means the handling is verified well enough to prepare an upstream PR.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, react-native
Domain
devtools
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.