microsoft / microsoft/react-native-windows
Remove Patch in TextInputExample.windows.js After React Alter TextInput Children
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
An edit to TextInputSharedExamples.windows.js created an error in our E2E tests because the example was not written in valid TextInput format. Example was changed in 5/31 integration to resume successful E2E tests.
Meta has decided to alter React to accept raw text children for the TextInput appointment. Thus they are leaving the example as is until that change goes through. We should remove our patch in TextInputExample.js once React is changes. See #13342 for the patch.
Commit: https://github.com/facebook/react-native/commit/c046198cc9ad9b3b7bf1b94fd1d8915681681a6e
Integration: https://github.com/microsoft/react-native-windows/pull/13298
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Check the React Native commit and integration PR referenced in the issue first, then inspect the patch from #13342 and the TextInput example files named in the report. Once React accepts raw TextInput children, remove the Windows-specific patch and verify that the E2E tests pass with the original example format.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- desktop, testing
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100