microsoft / microsoft/react-native-windows

Add E2E Snapshot Tests for ActivityIndicator

Open
#12,914 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area: ActivityIndicator Area: Fabric Area: Paper Area: Tests enhancement New Architecture Old Architecture Workstream: Test Coverage
Dominant language
C++
Stars
17.3k
Forks
1.2k
Avg merge
1d 13h
Merged PRs (30d)
33

Description

Add E2E Jest Snapshot Tests for ActivityIndicator. Tests should exist as samples within RNTester.

STATUS TYPES

Status Description
Not Implemented Prop is not implemented for given architecture.
Not Completed No test or sample exists for the prop.
Sample Completed Sample exists for the prop, but sample is not run in a Jest Snapshot Test.
Completed Sample and Snapshot test exists for the prop.

PROPS STATUS FOR IMAGE

Test Description Status (Paper) Status (Fabric) Notes
Default
  • [x] Sample Completed – RNTester
  • [x] Completed
AccessibilityHint
  • [ ] Not Completed
  • [ ] Not Completed
AccessibilityLabel
  • [x] Sample Completed - RNTester
  • [x] Completed
AccessibilityActions
  • [ ] Not Completed
  • [ ] Not Completed
AccessibilityRole
  • [ ] Not Completed
  • [ ] Not Completed
AccessibilityValue
  • [ ] Not Completed
  • [ ] Not Completed
AccessibilityPosInSet
  • [ ] Not Completed
  • [x] Completed
AccessibilitySetSize
  • [ ] Not Completed
  • [x] Completed
AccessibilityLiveRegion
  • [ ] Not Completed
  • [x] Completed
ImportantforAccessibility – no-hide-descendants
  • [ ] Not Completed
  • [ ] Not Completed
testID
  • [ ] Not Completed
  • [x] Completed
Style – backgroundColor
  • [x] Sample Completed - RNTester
  • [x] Completed
Style – borderBottomColor Not Implemented
  • [ ] Not Completed
Style – borderBottomEndRadius
  • [ ] Not Completed
  • [ ] Not Completed
Style – borderBottomLeftRadius
  • [x] Sample Completed - RNTester
  • [ ] Not Completed
Style – borderBottomRightRadius
  • [x] Sample Completed - RNTester
  • [ ] Not Completed
Style – borderBottomStartRadius
  • [ ] Not Completed
  • [ ] Not Completed
Style – borderBottomWidth
  • [ ] Not Completed
  • [ ] Not Completed
Style – borderColor
  • [x] Sample Completed - RNTester
  • [ ] Not Completed
Style – borderEndColor Not Implemented
  • [ ] Not Completed
Style – borderLeftColor Not Implemented
  • [ ] Not Completed
Style – borderLeftWidth
  • [ ] Not Completed
  • [ ] Not Completed
Style – borderRadius
  • [x] Sample Completed - RNTester
  • [ ] Not Completed
Style – borderRightColor Not Implemented
  • [ ] Not Completed
Style – borderStartColor Not Implemented
  • [ ] Not Completed
Style – borderStyle Not Implemented
  • [ ] Not Completed
Style – borderTopColor Not Implemented
  • [ ] Not Completed
Style – borderTopEndRadius
  • [ ] Not Completed
  • [ ] Not Completed
Style – borderTopLeftRadius
  • [x] Sample Completed - RNTester
  • [ ] Not Completed
Style – borderTopRightRadius
  • [x] Sample Completed - RNTester
  • [ ] Not Completed
Style – borderTopStartRadius
  • [ ] Not Completed
  • [ ] Not Completed
Style – borderTopWidth
  • [ ] Not Completed
  • [ ] Not Completed
Style – borderWidth
  • [x] Sample Completed - RNTester
  • [x] Completed
Style – elevation Not Implemented
  • [ ] Not Completed
Style – opacity
  • [x] Sample Completed - RNTester
  • [ ] Not Completed
Style – height
  • [x] Sample Completed - RNTester
  • [x] Completed
Style –width
  • [x] Sample Completed - RNTester
  • [ ] Not Completed/li>
Style – overflow
  • [ ] Not Completed
  • [x] Completed
Style – backfaceVisibility
  • [ ] Not Completed
  • [ ] Not Completed
Accessible
  • [x] Sample Completed - RNTester
  • [x] Completed
Focusable
  • [ ] Not Completed
  • [ ] Not Completed
HitSlop
  • [ ] Not Completed
  • [ ] Not Completed
NativeID
  • [ ] Not Completed
  • [ ] Not Completed
NextFocus*
  • [ ] Not Completed
  • [ ] Not Completed
onAccessibilityAction
  • [ ] Not Completed
  • [ ] Not Completed
onAccessibilityTab
  • [ ] Not Completed
  • [ ] Not Completed
onAccessibilityEscape
  • [ ] Not Completed
  • [ ] Not Completed
onLayout
  • [ ] Not Completed
  • [x] Completed
onMoveShoudlSetResponder
  • [ ] Not Completed
  • [ ] Not Completed
onMoveShouldSetResponderCapture
  • [ ] Not Completed
  • [ ] Not Completed
onResponderGrant
  • [ ] Not Completed
  • [ ] Not Completed
onResponderMove
  • [ ] Not Completed
  • [ ] Not Completed
onResponserReject
  • [ ] Not Completed
  • [ ] Not Completed
onResponderRelease
  • [ ] Not Completed
  • [ ] Not Completed
onResponderTerminate
  • [ ] Not Completed
  • [ ] Not Completed
onResponderTerminationRequest
  • [ ] Not Completed
  • [ ] Not Completed
onStartShouldSetResponder
  • [ ] Not Completed
  • [ ] Not Completed
onStartShouldSetResponderCatpure
  • [ ] Not Completed
  • [ ] Not Completed
pointerEvents
  • [ ] Not Completed
  • [ ] Not Completed
removeClippedSubviews
  • [ ] Not Completed
  • [ ] Not Completed
needsOffscreenAlphaCompositioning
  • [ ] Not Completed
  • [ ] Not Completed
toolTip
  • [ ] Not Completed
  • [ ] Not Completed
onError
  • [x] Sample Completed - RNTester
  • [ ] Not Completed
onLoad
  • [x] Sample Completed - RNTester
  • [ ] Not Completed
onPartialLoad
  • [x] Sample Completed - RNTester
  • [ ] Not Completed
onLoadEnd
  • [x] Sample Completed - RNTester
  • [ ] Not Completed
onLoadStart
  • [x] Sample Completed - RNTester
  • [ ] Not Completed
onProgress
  • [x] Sample Completed - RNTester
  • [ ] Not Completed
animating
  • [x] Sample Completed - RNTester
  • [x] Completed
color
  • [x] Sample Completed - RNTester
  • [x] Completed
size
  • [x] Sample Completed - RNTester
  • [x] Completed

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the ActivityIndicator sample in RNTester and the existing E2E Jest snapshot-test entry points. Resolve the issue's mismatch between ActivityIndicator in the title and Image in the status table before choosing coverage. Done means the intended ActivityIndicator sample has corresponding snapshots for the agreed Paper and Fabric cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react-native
Domain
desktop-dev, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.