microsoft / microsoft/react-native-windows
Remove additional patch from Button.windows/win32.js following upstream fix.
Open
Nobody has claimed this yet.
Area: Button
enhancement
Integration Follow-up
Workstream: Releases and Integrations
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Meta migrated the button component from a class component to a functional component. In this conversion, I believe they forgot to include a forwardRef for the control which is needed for functional components to have ref data. We should alert Meta/submit a PR upstream. Once merged we can remove the additional lines we forked in Button.windows/win32.js.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading Button.windows/win32.js and checking the upstream Meta button change for the missing forwardRef. Done means the upstream fix is merged and the additional patch lines are removed from that file; no test is named in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react, react-native
- Domain
- frontend, mobile-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100