microsoft / microsoft/react-native-windows
Fix incompatible types with react-native-picker and tabIndex
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Problem Description
Recent integration brought in https://github.com/facebook/react-native/pull/41312/files which adds tabIndex to ViewPropsAndriod however we already define tabIndex in https://github.com/microsoft/react-native-windows/blob/4253b3ad364057dc95d982698e661dec1c69baab/vnext/src/Libraries/Components/View/ViewPropTypes.d.ts#L224.
Currently fixed just by commenting out the change in our ViewProps https://github.com/microsoft/react-native-windows/blob/d360db8df2914dd02a78ec377d6fae77d4dbde90/packages/%40office-iss/react-native-win32/src/Libraries/Components/View/ViewPropTypes.d.ts#L163
Error:
Steps To Reproduce
- Delete commented out tabIndex
- Error will occur
Expected Results
Error should not occur
CLI version
npx react-native -v
Environment
npx react-native info
Target Platform Version
10.0.19041
Target Device(s)
Desktop
Visual Studio Version
Visual Studio 2022
Build Configuration
Debug
Snack, code example, screenshot, or link to a repository
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the tabIndex declarations in vnext/src/Libraries/Components/View/ViewPropTypes.d.ts and packages/@office-iss/react-native-win32/src/Libraries/Components/View/ViewPropTypes.d.ts. Follow the reproduction steps by restoring the commented change, then run the relevant React Native Windows type check or build; done means the react-native-picker and tabIndex types compile without the reported conflict.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100