microsoft / microsoft/react-native-windows
[Fabric] Switch DeviceInfoModule size changed API
Open
Nobody has claimed this yet.
Area: DeviceInfo
Area: Fabric
enhancement
New Architecture
Workstream: Component Parity
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
As we move away from window messages and HWNDs, we will eventually want to move away from using MS::RN::ForwardWindowMessage for updating size changes. This issue is here to track the work.
Do we have an issue to switch this over to a real API that takes a size. Something like MS::RN::NotifyOfWindowSizeChanged(rns, size);
Originally posted by @acoates-ms in https://github.com/microsoft/react-native-windows/pull/12450#discussion_r1416157594
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating DeviceInfoModule and the MS::RN::ForwardWindowMessage path in the repository, then trace how size changes are currently forwarded. Done means the tracked size-change work has a concrete size-taking API direction and the existing message-based path is addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- api, desktop-dev
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100