microsoft / microsoft/react-native-windows
Implement JSI NativeState APIs, re-enable unit tests
@vmoroz is already working on this.
Since Nov 27, 2023.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Problem Description
As part of the #12406 integrate, some new unit tests were added to test the JSI NativeState APIs (hasNativeState, getNativeState and setNativeState).
Those tests failed because we haven't implemented those APIs.
To get the integration unblocked, I've disabled the tests and opened this issue to track implementing the APIs and re-enabling the tests.
I've gone ahead and added TODO: #12425 in the places in-code where I think this needs to be addressed.
Steps To Reproduce
Run the Microsoft.ReactNative.IntegrationTests, specifically the Runtimes/JSITest.
Expected Results
No response
CLI version
npx react-native -v
Environment
npx react-native info
Target Platform Version
None
Target Device(s)
No response
Visual Studio Version
None
Build Configuration
None
Snack, code example, screenshot, or link to a repository
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.