microsoft / microsoft/react-native-windows

Match ArrayBuffer Size Behavior to Upstream

Open
#12,210 1 comment 0 reactions 1 assignee View on GitHub

@vmoroz is already working on this.

Since Oct 9, 2023.

Area: JSI Area: Tests enhancement Integration Follow-up Workstream: Test Coverage
Dominant language
C++
Stars
17.3k
Forks
1.2k
Avg merge
1d 13h
Merged PRs (30d)
33

Description

Upstream recently made a change to the expected size for ArrayBuffer. Now the ArrayBuffer size should not return the value of the ByteLength property. A new test was added to testlib.cpp; currently this test fails in our CI. We should investigate what changes we need to make to match this new behavior and then remove our fork of the testlib.cpp file.

Commit: https://github.com/facebook/react-native/commit/9edbd7836313526d55c58a6cdef8dacc9a0c29ed

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.