microsoft / microsoft/react-native-windows
Integration tests broken with 'double-conversion/double-conversion.h'
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Problem Description
Recent integration pulls in Add JSI<->C++ bridging conversion for folly::dynamic which breaks our Microsoft.ReactNative.IntegrationTests with the error Error C1083: Cannot open include file: 'double-conversion/double-conversion.h': No such file or directory even when specifying the include file. File is currently overwritten, but we should find the reason and fix it upstream.
Steps To Reproduce
- Remove override
- Try to build integration tests
Expected Results
tests should build fine
CLI version
npx react-native -v
Environment
npx react-native info
Target Platform Version
10.0.19041
Target Device(s)
Desktop
Visual Studio Version
Visual Studio 2022
Build Configuration
Debug
Snack, code example, screenshot, or link to a repository
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by removing the current override and rebuilding Microsoft.ReactNative.IntegrationTests to reproduce the missing double-conversion/double-conversion.h include. Trace the recent JSI-to-C++ bridging conversion integration and determine why the header is unavailable even when its include path is specified. Done means the integration tests build successfully without the override and the underlying fix is addressed upstream.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- build-system, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100