microsoft / microsoft/react-native-windows

Add E2E Jest Snapshot Tests for Popup

Open
#11,284 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area: Fabric Area: Popup Area: Tests enhancement New Architecture Workstream: Test Coverage
Dominant language
C++
Stars
17.3k
Forks
1.2k
Avg merge
1d 13h
Merged PRs (30d)
33

Description

Add E2E Jest Snapshot Tests for Popup. Tests should exist as samples within RNTester.

STATUS TYPES

Status Description
Not Implemented Prop is not implemented for given architecture.
Not Completed No test or sample exists for the prop.
Sample Completed Sample exists for the prop, but sample is not run in a Jest Snapshot Test.
Completed Sample and Snapshot test exists for the prop.

PROPS STATUS FOR POPUP

Test Description Status (Paper) Status (Fabric) Notes
Default
  • [x] Completed – RNTester
  • [ ] Not Completed
isOpen
  • [x] Completed – RNTester
  • [ ] Not Completed
isLightDismissedEnabled
  • [x] Completed – RNTester
  • [ ] Not Completed
horizontalOffset
  • [x] Completed – RNTester 10/22
  • [ ] Not Completed
verticalOffset
  • [x] Completed – RNTester 10/22
  • [ ] Not Completed
onDismiss
  • [x] Completed – RNTester
  • [ ] Not Completed
Target
  • [x] Completed – RNTester
  • [ ] Not Completed
AccessibilityHint
  • [x] Completed - RNTester 10/22
  • [ ] Not Completed
AccessibilityLabel
  • [x] Completed - RNTester 10/22
  • [ ] Not Completed
AccessibilityActions
  • [ ] Not Completed
  • [ ] Not Completed
AccessibilityRole
  • [ ] Not Completed
  • [ ] Not Completed
AccessibilityValue
  • [ ] Not Completed
  • [ ] Not Completed
testID
  • [x] Completed - RN Tester
  • [ ] Not Completed
accessible
  • [ ] Not Completed
  • [ ] Not Completed
focusable
  • [ ] Not Completed
  • [ ] Not Completed
HitSlop
  • [ ] Not Completed
  • [ ] Not Completed
NativeID
  • [x] Completed - RNTester 10/22
  • [ ] Not Completed
NextFocus* Not Implemented
  • [ ] Not Completed
onAccessibilityAction
  • [ ] Not Completed
  • [ ] Not Completed
onAccessibilityTab
  • [ ] Not Completed
  • [ ] Not Completed
onAccessibilityEscape
  • [ ] Not Completed
  • [ ] Not Completed
onLayout
  • [ ] Not Completed
  • [ ] Not Completed
onMoveShoudlSetResponder
  • [ ] Not Completed
  • [ ] Not Completed
onMoveShouldSetResponderCapture
  • [ ] Not Completed
  • [ ] Not Completed
onResponderGrant
  • [ ] Not Completed
  • [ ] Not Completed
onResponderMove
  • [ ] Not Completed
  • [ ] Not Completed
onResponserReject
  • [ ] Not Completed
  • [ ] Not Completed
onResponderRelease
  • [ ] Not Completed
  • [ ] Not Completed
onResponderTerminate
  • [ ] Not Completed
  • [ ] Not Completed
onResponderTerminationRequest
  • [ ] Not Completed
  • [ ] Not Completed
onStartShouldSetResponder
  • [ ] Not Completed
  • [ ] Not Completed
onStartShouldSetResponderCatpure
  • [ ] Not Completed
  • [ ] Not Completed
pointerEvents
  • [ ] Not Completed
  • [ ] Not Completed
removeClippedSubviews
  • [ ] Not Completed
  • [ ] Not Completed
needsOffscreenAlphaCompositioning
  • [ ] Not Completed
  • [ ] Not Completed
toolTip Not Implemented
  • [ ] Not Completed

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Popup sample in RNTester and inspect the existing Jest snapshot test structure for comparable components. Cover the applicable Popup props and Paper/Fabric statuses listed here, adding snapshots so each completed case has both a sample and snapshot coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native
Domain
testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.