microsoft / microsoft/react-native-windows
[Fabric] Update SetTopLevelWindowHandle to use a WindowId instead of a UInt64
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Update SetTopLevelWindowHandle to use a WindowId instead of a UInt64. This currently requires a newer version of the SDK than we are currently using but maybe by the time we look at shipping fabric we'll have other reasons to move to a newer SDK version.
https://github.com/microsoft/react-native-windows/pull/11218
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the SetTopLevelWindowHandle implementation and PR #11218, then check the Windows SDK version currently used by the project. Confirm when WindowId is available instead of UInt64 and update the Fabric call accordingly; done means the change builds against the selected SDK and the relevant tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- desktop, operating-systems
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100