microsoft / microsoft/react-native-windows

Add E2E Snapshot Tests for Button

Open
#11,198 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area: Button Area: Fabric Area: Tests enhancement good first issue New Architecture Workstream: Test Coverage
Dominant language
C++
Stars
17.3k
Forks
1.2k
Avg merge
1d 13h
Merged PRs (30d)
33

Description

Add E2E Jest Snapshot Tests for Button. Tests should exist as samples within RNTester.

STATUS TYPES

Status Description
Not Implemented Prop is not implemented for given architecture.
Not Completed No test or sample exists for the prop.
Sample Completed Sample exists for the prop, but sample is not run in a Jest Snapshot Test.
Completed Sample and Snapshot test exists for the prop.

PROPS STATUS FOR BUTTON

Test Description Status (Paper) Status (Fabric) Notes
Default Case
  • [x] Completed – RNTester
  • [x] Completed
AccessibilityLabel
  • [x] Completed – RNTester
  • [x] Completed
AccessibilityActions
  • [ ] Not Completed
  • [ ] Not Completed
AccessibilityRole
  • [x] Completed – RNTester 10/22 Pass
  • [x] Completed
AccessibilityHint
  • [x] Completed – RNTester 10/22 Pass
  • [x] Completed
AccessibilityState
  • [x] Completed – RNTester
  • [x] Completed
AccessibilityPosInSet
  • [ ] Not Completed
  • [x] Completed
AccessibilitySetSize
  • [ ] Not Completed
  • [x] Completed
AccessibilityValue
  • [ ] Not Completed
  • [x] Completed
AccessibilityLiveRegion
  • [x] Completed – RNTester
  • [x] Completed
onAccessibilityAction
  • [ ] Not Completed
  • [ ] Not Completed
onPress
  • [x] Completed – RNTester
  • [x] Completed
Color
  • [x] Completed – RNTester
  • [x] Completed
Disabled
  • [x] Completed – RNTester
  • [x] Completed
testID
  • [x] Completed – RNTester
  • [x] Completed
Style – elevation Not Implemented Not Implemented
Accessible
  • [x] Completed – RNTester 10/22 Pass
  • [x] Completed
Focusable
  • [x] Completed – RNTester 10/22 Pass
  • [x] Completed
NextFocus* Not Implemented Not Implemented

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Button sample within RNTester and the existing Jest snapshot-test setup. Compare the sample with the props marked Not Completed in the status table, accounting for Paper and Fabric. Done means the applicable Button samples are covered by E2E Jest snapshots and the expected snapshots pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native
Domain
mobile, testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.