microsoft / microsoft/react-native-windows

Remove NativeAnimatedHelper.win32.js override

Open
#11,041 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Deforking Integration Follow-up Platform: NetUI Workstream: Releases and Integrations
Dominant language
C++
Stars
17.3k
Forks
1.2k
Avg merge
1d 13h
Merged PRs (30d)
33

Description

Problem Description

Integration of this commit from upstream breaks the RN win32 tester app due to the Native animation module not being implemented on win32.

Steps To Reproduce
  1. Remove override and run win32 tester app
  2. Open Button page, tester will crash due to hitting invariant.
Expected Results

No response

CLI version

npx react-native --version

Environment
npx react-native info
Target Platform Version

None

Target Device(s)

No response

Visual Studio Version

None

Build Configuration

None

Snack, code example, screenshot, or link to a repository

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the NativeAnimatedHelper.win32.js override and the win32 tester app's Button page. Reproduce the crash after removing the override, then verify that the tester app no longer hits the Native animation invariant and that the relevant app behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react-native
Domain
desktop-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.