microsoft / microsoft/react-native-windows
Add BigInt and NativeState APIs
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
Problem Description
Latest integrations added more methods to BigInt and a API for setting/getting Native State. Unfortunately, Hermes versioning is still being worked through and there wasn't a way to match JSI at that point in time causing an JSI ABI break.
Currently we override the necessary JSI files to get built to work.
https://github.com/facebook/react-native/commit/a21a1f845bd854f01cac905a4737a360cca0cd12
https://github.com/facebook/react-native/commit/61792339657b12f43318e842aba48c7043e40168
Steps To Reproduce
- Remove JSI overrides in ReactCommonTemp
- Try to build react-native-windows
- If you add the BigInt and NativeState APIs, chakra will run fine but hermes will break after opening the app
Expected Results
No response
CLI version
npx react-native --version
Environment
npx react-native info
Target Platform Version
No response
Target Device(s)
No response
Visual Studio Version
No response
Build Configuration
No response
Snack, code example, screenshot, or link to a repository
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.