microsoft / microsoft/react-native-windows

Remove hermes/inspector/chrome/ConnectionDemux.cpp override

Open
#10,370 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area: JavaScript Engine bug Deforking Workstream: Developer Experience
Dominant language
C++
Stars
17.3k
Forks
1.2k
Avg merge
1d 13h
Merged PRs (30d)
33

Description

Problem Description

To provide a temporary fix for 9662, I'm adding TEMP_UntilReactCommonUpdate/hermes/inspector/chrome/ConnectionDemux.cpp. The corresponding upstream PR is 34342.

This issue is meant to track the removal of the override depending on the upstream acceptance of the change.

Steps To Reproduce

see issue 9662

Expected Results

No response

CLI version

8.0.2

Environment
System:
    OS: Windows 10 10.0.22000
    CPU: (32) x64 AMD Ryzen Threadripper PRO 3955WX 16-Cores
    Memory: 111.35 GB / 127.86 GB
  Binaries:
    Node: 16.14.2 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.18 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.5.0 - C:\Program Files\nodejs\npm.CMD
    Watchman: Not Found
  SDKs:
    Android SDK: Not Found
    Windows SDK:
      AllowDevelopmentWithoutDevLicense: Enabled
      AllowAllTrustedApps: Enabled
  IDEs:
    Android Studio: Not Found
    Visual Studio: 17.2.32602.215 (Visual Studio Enterprise 2022), 16.11.32602.291 (Visual Studio Enterprise 2019)
  Languages:
    Java: 11.0.12 - C:\Program Files\Microsoft\jdk-11.0.12.7-hotspot\bin\javac.EXE
  npmPackages:
    @react-native-community/cli: Not Found
    react: Not Found
    react-native: Not Found
    react-native-windows: Not Found
  npmGlobalPackages:
    *react-native*: Not Found
Target Platform Version

No response

Target Device(s)

No response

Visual Studio Version

No response

Build Configuration

No response

Snack, code example, screenshot, or link to a repository

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Check upstream PR 34342 and issue 9662 first. The temporary override is at TEMP_UntilReactCommonUpdate/hermes/inspector/chrome/ConnectionDemux.cpp; once the upstream change is available, remove that override and verify the behavior described by issue 9662.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, react-native
Domain
desktop, devtools
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.