microsoft / microsoft/react-native-windows

UISettings TextScaleFactor change should trigger a re-layout

Open
#10,253 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Area: Accessibility Area: Layout enhancement Workstream: Accessibility
Dominant language
C++
Stars
17.3k
Forks
1.2k
Avg merge
1d 13h
Merged PRs (30d)
33

Description

This was found through gallery's accessibility testing. When size of text is scaled up from settings, some of the controls are truncated because it looks like the now larger text no longer fits in the space allocated. If you leave and re-enter a page, it is fixed. As in XAML, we should be listening for this change and trigger an immediate re-layout to respond to the text size change.

Some examples from RNTester:
image
image
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the UISettings TextScaleFactor handling and the existing layout invalidation path in react-native-windows. Reproduce the issue in RNTester by changing the text scale setting while a page is open; done means affected controls re-layout immediately without leaving and re-entering the page.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, react-native
Domain
accessibility, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.