microsoft / microsoft/react-native-windows
Sync dev server URL parameters with core
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 17.3k
- Forks
- 1.2k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 33
Description
BundleUrlFormat has changed in core but we haven't kept up with it
I think this was originally copied from https://github.com/facebook/react-native/blob/8a2be3e1438dd145ccb5374d6ef60811047d23aa/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java#L436
Looks like their URL has changed a bunch since we copied it (we might want to look into what these new URL params are). But they are hard coding http://. No real reason we couldn't allow it to be specified though.
react-native/DevServerHelper.java at 8a2be3e1438dd145ccb5374d6ef60811047d23aa · facebook/react-nativeA framework for building native applications using React - react-native/DevServerHelper.java at 8a2be3e1438dd145ccb5374d6ef60811047d23aa · facebook/react-nativegithub.com
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in vnext/Shared/DevServerHelper.h at BundleUrlFormat and compare its URL construction with the referenced React Native core implementation. Identify the URL parameters that have changed and verify the Windows dev-server URL matches the current core format; consider the issue's note about allowing the protocol to be specified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, react-native
- Domain
- developer-experience, devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100