microsoft / microsoft/react-native-test-app
Revisit support for multiline messages in problem matchers
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 674
- Forks
- 97
- Avg merge
- 21h 43m
- Merged PRs (30d)
- 20
Description
Due to a limitation in the format of problem matchers, it's currently not possible to extract multiline messages. For input such as:
TestTestApp#test_resources_pod_returns_spec_path [test/test_test_app.rb:31]:
Expected: ".."
Actual: "."
"Expected: …" and "Actual: …" are two separate errors with this matcher. We are currently not able to match output such as:
TestTestApp#test_resources_pod_writes_podspec [test/test_test_app.rb:50]:
--- expected
+++ actual
@@ -1 +1 @@
-["dist/assetd", "dist/main.jsbundle"]
+["dist/assets", "dist/main.jsbundle"]
This issue has been reported in https://github.com/actions/toolkit/issues/193 and https://github.com/actions/toolkit/issues/319.
Originally posted by @tido64 in https://github.com/microsoft/react-native-test-app/pull/61/review_comment/create
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the problem matcher format and the linked GitHub Actions issues #193 and #319; the example output comes from test/test_test_app.rb. Determine how multiline expected/actual output should be represented, then verify that each multiline failure is reported as one diagnostic rather than separate errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, typescript
- Domain
- testing-qa, tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 28/100