microsoft / microsoft/react-native-gallery
Add FURN (fluent-ui-react-native) to Gallery
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 257
- Forks
- 57
- Avg merge
- 18h 19m
- Merged PRs (30d)
- 10
Description
(drive by comment) If using a JS only control, the FURN Radiogroup might be an option
I love drive by comments from Saad!
You're right. And it'd be more Fluent than the cross-platform module I used (see #411). As is I provided 2 samples:
- cross-platform module (not Fluent)
- react-native-xaml Windows-specific (very Fluent)
FURN would solve both.
Buuuuuut.... to incorporate FURN into Gallery (Which I want to do! Will open an issue from this comment), I think we first need to address these:
- Required explicit importing of SVG (see https://github.com/microsoft/fluentui-react-native/issues/2613)
- Required switching to classic runtime (see https://github.com/microsoft/fluentui-react-native/issues/1891)
- Updates to the Windows visual theme (see this override)
(I hit these when developing this: https://github.com/chrisglein/artificial-chat/pull/116)
Maybe we can partner up and fixing these and getting FURN in this Gallery app?
Originally posted by @chrisglein in https://github.com/microsoft/react-native-gallery/issues/404#issuecomment-2076053883
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the prerequisite issues #2613 and #1891, then inspect the Windows visual-theme override referenced from artificial-chat PR #116. Done means the Gallery app incorporates FURN and addresses the explicit SVG imports, classic runtime, and Windows theme updates identified in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100