`self.N == 0` in ops.py indicates expanding is too misleading and could easily result in bugs
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Python
- Stars
- 48.7k
- Forks
- 7.7k
- PR merge metrics
- No merged PRs in 30d
Description
Problem
it is too misleading and could easily result in bugs to make self.N == 0 in ops.py indicates expanding window
Expected behavior
self.N == 0 in Rolling Ops will result in 1 window size. It can go to the expanding window branch when self.N is None (or not given )
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading qlib/data/ops.py around line 698 and trace how Rolling Ops interpret self.N. Verify the expected distinction: self.N == 0 uses a one-window size, while self.N is None selects expanding-window behavior; completion should include coverage for both cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100