[Question] Why not check if the time interval exceeds the step size
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 48.7k
- Forks
- 7.7k
- PR merge metrics
- No merged PRs in 30d
Description
Why not check if the time interval exceeds the step size? And if it doesn't, shouldn't we return an empty list?
interval = self.ta.cal_interval(calendar_latest, max_test[0])
if interval < self.rg.step:
return []
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at qlib/workflow/online/strategy.py lines 181-188 and trace how self.ta.cal_interval, calendar_latest, max_test[0], and self.rg.step are defined and used. Determine whether the interval check matches the intended behavior, then verify the expected result for an interval below the step size; done means the behavior is resolved and covered by the relevant workflow tests, if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- fintech-quant
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100