[question] why not droping duplicates such as save_new_companies function?
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 48.7k
- Forks
- 7.7k
- PR merge metrics
- No merged PRs in 30d
Description
shall we do it like this:
new_df = new_df.drop_duplicates([self.SYMBOL_FIELD_NAME]) ????
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at scripts/data_collector/index.py around line 228 and inspect save_new_companies, especially how new_df and SYMBOL_FIELD_NAME are used. Determine whether duplicate symbols are invalid for this collector, then verify the decision against the surrounding data flow and any relevant tests; done means the duplicate-handling behavior is explicit and validated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data-engineering
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100