microsoft / microsoft/qlib

Data is fetched twice in CSI500 index collector

Open
#1,729 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
48.7k
Forks
7.7k
PR merge metrics
No merged PRs in 30d

Description

https://github.com/microsoft/qlib/blob/98f569eed2252cc7fad0c120cad44f6181c3acf6/scripts/data_collector/cn_index/collector.py#L401-L408

result is overwritten with the call to self.get_data_from_baostock(date), and that function contains exactly the same code as the lines above the overwrite. Might be an oversight during refactoring.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open scripts/data_collector/cn_index/collector.py around lines 401-408 and compare the code before the result overwrite with get_data_from_baostock(date). Confirm the collector fetches the data only once and that the resulting value is preserved after the redundant operation is removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data-engineering
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.