microsoft / microsoft/qlib

MetaModelInc module offline training should call eval for validation predict.

Open
#1,722 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
48.7k
Forks
7.7k
PR merge metrics
No merged PRs in 30d

Description

🐛 Bug Description

To Reproduce

Steps to reproduce the behavior:

  1. create any module with bn or dropout layer
  2. run offline training
  3. inloop training missed model.eval(), caused batch normalization or dropout layer cannot work as predict model.

Expected Behavior

prediction should not dropout any value or using dynamic batch mean and var for batch normalization. The run_task function should be modified from :

def run_task(self, meta_input, phase):
""" A single naive incremental learning task """
.........
with torch.no_grad():
pred = self.framework(meta_input["X_test"].to(self.framework.device), None)
return pred.detach().cpu().numpy()
to
def run_task(self, meta_input, phase):
""" A single naive incremental learning task """
.........
with torch.no_grad():
self.framework.eval()
pred = self.framework(meta_input["X_test"].to(self.framework.device), None)
return pred.detach().cpu().numpy()

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating MetaModelInc's run_task method and reproduce offline training with a module containing batch normalization or dropout. Verify the validation prediction path switches the framework to evaluation mode and confirm predictions no longer apply dropout or training-time batch statistics.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, pytorch
Domain
machine-learning
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.