microsoft / microsoft/qdk

Introduce RIR visitor to reduce code duplication

Open
#3,051 0 comments 0 reactions 0 assignees View on GitHub
enhancement needs triage
Dominant language
Rust
Stars
1k
Forks
212
Avg merge
3d 8h
Merged PRs (30d)
65

Description

There are places in the code, most prominently the QIR code generation paths, where there is a mix of processing and traversal logic. To split those and avoid some code duplication, we should introduce a visitor pattern like what we use for other IRs inside our repo.

Contributor guide

Open the contributing guide

Research direction

Start by reading the existing visitor implementations for other IRs in the repository, then inspect the QIR code generation paths where traversal and processing are mixed. Define the visitor boundary and confirm that the affected paths use it without duplicated traversal logic; the issue does not name specific files or tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.