[Samples] Investigate redundant Check
- Dominant language
- Rust
- Stars
- 1k
- Forks
- 212
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 65
Description
**Is your feature request related to a problem? Please describe.**
There exists a typescript test that executes samples in samples.mjs ([Code link](https://github.com/microsoft/qsharp/blob/d1fb2a164a3ec4db73506beda3a70e097ddaacc9/npm/qsharp/test/basics.js#L350-#L370) ) . IMO, it would be good to investigate whether it is relevant in the current scenario after this repo has been enhanced for testing efficiency primarily in #1533 #1797. As per my understanding we are now checking for lint and sample execution for all samples, so it might be a good idea to get rid of redundancy.
**Describe the solution you'd like**
A clear and concise description of what you want to happen.
Get rid of redundant test if its no longer required.
**Describe alternatives you've considered**
Dont remove the test if its needed.
**Additional context**
- Earlier, observation raised in https://github.com/microsoft/qsharp/issues/1709 based on Q# infra at the time of raising the issue.
- See [this comment](https://github.com/microsoft/qsharp/pull/1797/files/f37e2d35c2e10de59fa2473590405706c2336492#r1723613762)
Contributor guide
Research direction
Start with the sample-execution test in npm/qsharp/test/basics.js around lines 350-370 and compare it with the current sample linting and execution checks described in issues #1533 and #1797. Verify whether the test still covers a distinct case; remove it if redundant, or retain it if it provides unique coverage, then run the relevant qsharp tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100