microsoft / microsoft/qdk

Update `rustc_hash` and come to terms with the consequences

Open
#1,877 1 comment 0 reactions 1 assignee Claimed by @ScottCarda-MS View on GitHub
bug low-priority
Dominant language
Rust
Stars
1k
Forks
212
Avg merge
3d 8h
Merged PRs (30d)
65

Description

We appear to iterate over some hash maps in some places. Updating `rustc_hash` to a `2.x.x` version causes all sorts of snapshot tests to fail with ordering issues.

I think we have two options:
1. Investigate these iterations and make them deterministic where important.
2. Update `rustc_hash` when we do a breaking change, so that our ordering can as well change.

Or...stay on `1.x.x` forever?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.