microsoft / microsoft/qdk-ec

Wrong docstring in `CliffordUnitary::from_images`

Open Beginner friendly
#167 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
64
Forks
16
Avg merge
1d 5h
Merged PRs (30d)
5

Description

The following doc string states that images are provided in groups (first all X, then all Z):

https://github.com/microsoft/qdk-ec/blob/96dc7dee7393a5650db439c6e1ac192dc1101578/paulimer/bindings/python/paulimer.pyi#L513-L519

However, the underlying Rust implementation expects them in interleaved order:

https://github.com/microsoft/qdk-ec/blob/96dc7dee7393a5650db439c6e1ac192dc1101578/paulimer/src/clifford/generic_algos.rs#L345-L350

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the docstring in paulimer/bindings/python/paulimer.pyi around lines 513-519 with the implementation in paulimer/src/clifford/generic_algos.rs around lines 345-350. Update the documentation so it accurately describes the ordering expected by the implementation. Done when the docstring no longer conflicts with the Rust code.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
90/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.