Multiple problems in TurnRatio Playground
Open
@kimprice is already working on this.
Since Sep 11, 2023.
- Dominant language
- TypeScript
- Stars
- 2.3k
- Forks
- 641
- Avg merge
- 12h 4m
- Merged PRs (30d)
- 57
Description
The Playground example for Range is wrong!
Problem 1: There is a typo, it should be
//% turnRatio.shadow=turnRatioPicker
with a big R instead of
//% turnratio.shadow=turnRatioPicker
Problem 2: Min Max can't be specified here. I think the Problem is in the file field_turnratio
constructor(value_: any, params: FieldTurnRatioOptions, opt_validator?: Function) {
super(String(value_), '-200', '200', '1', '10', 'TurnRatio', opt_validator);
this.params = params;
(this as any).sliderColor_ = '#a8aaa8';
}
It looks like the min max values are preset with -200 and 200.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.