microsoft / microsoft/pxt

incorrect function value capture

Open
#8,172 0 comments 0 reactions 1 assignee View on GitHub

@mmoskal is already working on this.

Since May 19, 2021.

Dominant language
TypeScript
Stars
2.3k
Forks
641
Avg merge
12h 4m
Merged PRs (30d)
57

Description

The following crashes on hardware (and probably sim as well):

function bugTest() {
   let q = 0
   function foo() { // const foo = () => { // fixes the issue
     q++
   }
   const tmp = () => {
     const bar = foo // here foo is referenced as if we were in bugTest; instead it should be captured
     if (typeof bar != "function")
       throw "oops"
   }
   tmp()
}
bugTest()

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.