microsoft / microsoft/pxt

PXT package.json dependencies - some might actually be needed at dev time only?

Open
#7,882 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
2.3k
Forks
641
Avg merge
12h 4m
Merged PRs (30d)
57

Description

Just saw this - might be intended but there are a few libs that are usually only used during the build/testing process.

Might be alright since it is a build tool? Just double checking cause it's the kind of thing I'd accidentally do. If not used at runtime they can probably move over to devDependencies.

    "bluebird": "3.5.1",
    "faye-websocket": "0.11.1",
    "lzma": "2.3.2",
    "marked": "0.3.19",
    "rimraf": "2.5.4",
    "request": "2.88.0",
    "pngjs": "3.4.0",
    "browserify": "16.2.0", < REVIEW
    "uglify-js": "3.3.21", < REVIEW
    "postcss": "6.0.21",
    "rtlcss": "2.2.1",
    "cssnano": "4.1.10",
    "less": "2.7.3",  < REVIEW
    "semantic-ui-less": "2.2.14", < REVIEW
    "applicationinsights-js": "^1.0.20",
    "mocha": "5.1.0",
    "chai": "^3.5.0",
    "karma": "4.4.1",
    "karma-chai": "0.1.0",
    "karma-chrome-launcher": "3.1.0", < REVIEW
    "karma-mocha": "1.3.0",
    "puppeteer": "^2.0.0", < REVIEW
    "dompurify": "2.0.8",
    "sanitize-html": "1.22.0"
  },```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with package.json and trace each listed dependency through the build and test configuration, especially the entries marked REVIEW. Check whether each package is required at runtime or only during development, then verify that builds and tests still work after any justified dependency classification changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
build-system, tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.