microsoft / microsoft/pxt

The close button for the help window seems to be easily lost

Open
#7,726 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
2.3k
Forks
641
Avg merge
12h 4m
Merged PRs (30d)
57

Description

In the office we usability tested the close button on the help window - seems like everyone missed the chevron on the left. The window feels like it is stuck open.

Repro steps
Open any pxt, I used arcade
Drag out a block
Right click on the block, choose help
Now try to get rid of the modeless dialog that appears.

Results
Everyone naturally went to the (open external tab) to try to close it. In my pxt I have worked around this by styling the chevron to attract attention..

--

image

image

Not suggesting you take my fix, but I did put the same shadow for the handle under the toggle button so it looks like it is actually part of the window. Then I made it a horrid orange. Still debating that one. 🤔

Adding standard close (x) next to the open external might be better.

/** the default toggle isnt visible enough to see the close mechanism*/
#sidedocsframe-wrapper {
    border: 2px solid #2b3550;
}
#sidedocstoggle {
    background: #d7674e;
    z-index: 999;
    opacity: 1;
    box-shadow: 0px 0px 20px 0px rgba(0, 0, 0, 0.41) !important;
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Reproduce the help-window flow, then search for the sidedocsframe-wrapper and sidedocstoggle styles and the help dialog entry point. Done means the modeless help window has an obvious, usable way to close and the relevant UI tests or manual reproduction confirm it.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, typescript
Domain
design, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.