microsoft / microsoft/pxt

tree shaking doesn't get rid of dead hex literal

Open
#7,690 1 comment 0 reactions 1 assignee View on GitHub

@mmoskal is already working on this.

Since Dec 4, 2020.

bug compiler
Dominant language
TypeScript
Stars
2.3k
Forks
641
Avg merge
12h 4m
Merged PRs (30d)
57

Description

  • see https://makecode.microbit.org/_fY9cVRgEp1VD and the compiler error on download
  • the variable rocketJourney in animations.ts (let clause) is not used anywhere in the code.
  • if you comment out this line, the project builds.
  • if you uncomment the line, the project fails

The same problem occurs if you replace "let" with "const" in animations.ts

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.