microsoft / microsoft/pxt

One off page issues on safari

Open
#7,248 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
2.3k
Forks
641
Avg merge
12h 4m
Merged PRs (30d)
57

Description

Describe the bug

A few bugs running makecode tools on safari:

makecode.com/multi:

[Error] SecurityError: IDBFactory.open() called in an invalid security context
	e (main.js:1:967098)
	(anonymous function) (main.js:1:967155)
[Error] TypeError: undefined is not an object (evaluating 'H.reloadEditor')
	(anonymous function) (main.js:1:97845)
	(anonymous function) (main.js:1:105550)

first happens each reload, second happened only first time after bump. Stuck spinning for me, works on all but microbit.

makecode.com/tutorial-tool:

[Error] Failed to load resource: the server responded with a status of 404 () (dapjs.js.map, line 0)
https://pxt.azureedge.net/commit/23c3d8c7f8a0f44f7681d1e3de648cb6b67220d2/dapjs.js.map

looks like this:

image

makecode.com/playground:

Screen Shot 2020-06-25 at 12 12 40 PM

streamer:

[Error] Error while parsing the 'sandbox' attribute: 'allow-downloads' is an invalid sandbox flag. (streamer, line 1073)
[Error] Error while parsing the 'sandbox' attribute: 'allow-downloads' is an invalid sandbox flag. (streamer, line 1074)
[Error] Failed to load resource: the server responded with a status of 404 (Not Found) (undefined, line 0) //// NOTE; this one's trying to access https://makecode.com/undefined, which seems odd?
[Error] SecurityError: IDBFactory.open() called in an invalid security context
	e (main.js:1:967098)
	(anonymous function) (main.js:1:967155)
[Error] NotSupportedError: The operation is not supported.
(anonymous function) — script.js:1475
forEach
(anonymous function) — script.js:1472
asyncFunctionResume
[native code]
promiseReactionJob

	(anonymous function) (script.js:80)
	asyncFunctionResume
	(anonymous function)
	promiseReactionJob

@shakao the tutorial tool / playground tool issues just seem like css bugs, so probably hard to debug without a mac / I can fix it real quick if that sounds easier? at a glance it looks like .editor-row { height: 100% } is all that's needed for both tutorial tool and playground but have to check (and not sure about the failed dapjs.map fetch)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the Safari failures on makecode.com/multi, /tutorial-tool, /playground, and streamer. Start with the reported main.js and script.js locations, the missing dapjs.js.map request, and the .editor-row CSS suggestion; done means these pages load without the reported Safari errors, layout issues, or stuck spinner.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, typescript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.