microsoft / microsoft/pxt

Multiple sentences causes JSON to parse badly for strings files

Open
#4,979 0 comments 0 reactions 1 assignee View on GitHub

@pelikhan is already working on this.

Since Nov 8, 2018.

localization
Dominant language
TypeScript
Stars
2.3k
Forks
641
Avg merge
12h 4m
Merged PRs (30d)
57

Description

Sentence breaks in the JSON string values parse badly for translation string files.

The card source here, embedded in a markdown file, will result in two strings extracted string split at "New?" and "Start Here!". This is difficult to manage in Crowdin when applying translations.

Source:

{
    "name": "Prepare",
    "imageUrl": "/static/lessons/firmware.png",
    "description": "To use Microsoft MakeCode with your EV3 Brick, you will need to install the latest LEGO® MINDSTORMS® Education EV3 firmware.",
    "label": "New? Start Here!",
    "labelClass": "red ribbon large",
    "url": "https://makecode.mindstorms.com/troubleshoot"
}
]

This results in two strings for the card in Crowdin:

{
    "name": "Prepare",
    "imageUrl": "/static/lessons/firmware.png",
    "description": "To use Microsoft MakeCode with your EV3 Brick, you will need to install the latest LEGO® MINDSTORMS® Education EV3 firmware.",
    "label": "New?

and

Start Here!",
    "labelClass": "red ribbon large",
    "url": "https://makecode.mindstorms.com/troubleshoot"
}
]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.