microsoft / microsoft/pxt

No Math numerical negation block.

Open
#4,131 0 comments 0 reactions 1 assignee View on GitHub

@riknoll is already working on this.

Since May 15, 2018.

bug decompiler P2
Dominant language
TypeScript
Stars
2.3k
Forks
641
Avg merge
12h 4m
Merged PRs (30d)
57

Description

Issue #4109 comments on a round trip issue when decompiling from an expression using the '-=' subtraction assigment operator.

This issue suggests adding a negation block which would replace the '0 - x' hack in this decompilation.

For example,

material.roughness -= myroughness

would decompile to

image

but with a '-x' negation block replacing the '0 - x' expression.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.