microsoft / microsoft/pxt

TypeScript '-=' subtraction assignment operator not supported

Open
#4,109 2 comments 0 reactions 1 assignee View on GitHub

@riknoll is already working on this.

Since Apr 13, 2018.

bug decompiler P2
Dominant language
TypeScript
Stars
2.3k
Forks
641
Avg merge
12h 4m
Merged PRs (30d)
57

Description

(really an improvement more than a bug)

When code is decompiled back to blocks by the emitter the '-=' operator is not supported,
e.g.

material.roughness -= myroughness

becomes,

image

Similarly using a negative operand with the '+=' operator we get an interesting round-trip,

material.roughness += -myroughness

becomes,

image

and then when switching back to code,

material.roughness += 0 - myroughness

If we introduced a negative block that would return negated numerical input we could special case this block in conjunction with the change block as its parent to compile/decompile to/from the '-=' operator and its associated expression.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.