microsoft / microsoft/pxt-microbit
Console error reported for serial_redirect
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 804
- Forks
- 721
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 2
Description
Describe the bug
In a new project, the first opening of the Serial toolbox panel triggers a browser console error
I think this may be because the rate parameter description "e.g." is picked up as a default value
To Reproduce
Steps to reproduce the behavior:
- Go to https://makecode.microbit.org/
- Create a new project and open the browser console
- Open the Serial toolbox panel
- See error
Expected behavior
A correct default value is specified
Screenshots
micro:bit version (please complete the following information):
not hardware related
Desktop (please complete the following information):
- OS: [e.g. iOS] Windows
- Browser [e.g. chrome, safari] Chrome
- Version [e.g. 22]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect libs/core/serial.cpp around line 161 and libs/core/shims.d.ts around line 1068, then reproduce the issue by opening the Serial toolbox in a new project with the browser console open. Confirm the parameter metadata produces the reported console error, and consider the work complete when a correct default value is specified and the error no longer appears.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, typescript
- Domain
- frontend, tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100