microsoft / microsoft/pxt-microbit
Themes: Separate common-button and semantic UI button overrides
Open
@thsparks is already working on this.
Since Apr 3, 2025.
engineering
- Dominant language
- TypeScript
- Stars
- 804
- Forks
- 721
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 2
Description
React common buttons and semantic UI buttons share theme styling right now. This is nice because it reduces duplication, but a lot of specificity (or even !important) is required to override certain semantic UI rules, which isn't needed for react common. But that specificity can be frustrating when overriding a themed style elsewhere. I think it'll make more sense in the long term to have these separated so we don't have to make overly-specific css styles anytime we want to do something special with a button.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.