microsoft / microsoft/pxt-microbit

Include 'clap' as an option in the dropdown for 'loud' and 'quiet' sounds

Open
#5,097 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

apis
Dominant language
TypeScript
Stars
804
Forks
721
Avg merge
2d 9h
Merged PRs (30d)
2

Description

Since https://github.com/lancaster-university/codal-core/commit/99b9399857fd5e6110c2f0b9f2b3d134cd59e92d there's been a clean 'clap' event that tries to be a bit more specific than 'loud'. As I understand it, it's possible for a loud and a clap to fire for the same sound, but while a clap will always give you a corresponding 'loud' event, not every 'loud' event is a clap.

It has advantages like

  • working better for short/sharp sounds
  • not triggering on things like the user pressing the touch logo
  • detecting two claps separately, rather than as one 'loud' sound

Could 'clap' be added as a third option in the dropdown for 'on loud'
image

Or should this be an extension?
@JohnVidler should be able to help on implementation questions.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the editor definition for the “on loud” dropdown and trace how its existing sound options map to micro:bit events. Check the referenced CODAL commit and the current loud-event behavior, then add “clap” as an option if the integration supports it. Done means the dropdown exposes clap and the resulting blocks or JavaScript use the clap event distinctly from loud.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.