microsoft / microsoft/pxt-microbit

returning to code editor from serial view should not refresh simulator

Open
#4,743 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

P2 serial Simulator
Dominant language
TypeScript
Stars
804
Forks
721
Avg merge
2d 9h
Merged PRs (30d)
2

Description

Describe the bug

currently if you return to the code editor (e.g. blocks) after pressing show console simulator we refresh the simulator. We have already skipped that for going to serial view, should make it skip refresh when going from serial view -> any other.

Not a regression

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://makecode.microbit.org/_F0gd0uicv2kw
  2. open in editor
  3. click on 'show console simulator'
  4. click `go back'

Expected behavior

should just go back without affecting the simulator at all

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue using the linked MakeCode project: open the editor, show the console simulator, then go back to the code editor. Trace the serial-view navigation and verify that returning to any other editor view leaves the simulator unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.