microsoft / microsoft/pxt-microbit
Note() enum missing accidentals
Open
@riknoll is already working on this.
Since Mar 23, 2021.
help wanted
music
P2
- Dominant language
- TypeScript
- Stars
- 804
- Forks
- 721
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 2
Description
DESCRIPTION
It seems odd that to go from C4 to CSHARP4 to D4 to ... EB4 (and ditto for G4, GSHARP4, A4, BB4). Why not include DSHARP4 and ASHARP4? Trying to go up (or down) a chromatic scale and needing to switch accidentals in the middle seems peculiar.
EXPECTED BEHAVIOR
All of the flats and sharps of the chromatic scale should be included, rather than arbitrary switching from sharp to flat.
HARDWARE
micro:bit version 2.0
DESKTOP
- OS: Linux (Ubuntu Studio 20.04)
- Browser: Chromium (Version 88.0.4324.182) and Firefox (Version 86.0)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.