microsoft / microsoft/pxt-microbit
GitHub: Some actions that need a log in don't prompt for one
Open
@abchatra is already working on this.
Since Mar 29, 2021.
GitHubIntegration
P2
- Dominant language
- TypeScript
- Stars
- 804
- Forks
- 721
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 2
Description
Describe the bug
Some actions that need a log in don't prompt for one.
When not currently signed in, "Commit and push changes", for example, displays the "Sign in with GitHub" dialog, but other actions on the same page don't.
"Pull changes" displays a "something went wrong" error.
History, "View commits" spins.
Expected behavior
Should all actions that require a sign in prompt for one?
Desktop (please complete the following information):
- OS: [e.g. iOS] Windows, iOS
- Browser [e.g. chrome, safari] Chrome, Safari
- Version [e.g. 22]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.