microsoft / microsoft/powerquery-parser

[Enhancement] Add Parser Support for Invalid Syntax Literals

Open
#154 3 comments 0 reactions 1 assignee View on GitHub

@JordanBoltonMN is already working on this.

Since May 13, 2020.

enhancement
Dominant language
TypeScript
Stars
137
Forks
34
Avg merge
50m
Merged PRs (30d)
1

Description

Describe the solution you'd like
Power Query expressions can contain "invalid syntax literals" (unsure the official name), a syntax construct in the form of #!" … " which is not mentioned in the official language specification.

To enable this parser to fully parse the section documents created by Microsoft Excel and Power BI, both of which can output invalid syntax literals, would it make sense to extend the parser to support these literals?

Example (pulled verbatim from a Power BI file):

section Section1;

shared Query1 = let
    Source = #!"let a"
in
    Source;

Additional context
For more details on these literals, see https://github.com/MicrosoftDocs/powerquery-docs/issues/12.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.